[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [StrongED] StrongHelp 2.88a1 available
In message <ecdcf76154.fjgraute@xxxxxxxxx>
Fred Graute <fjgraute@xxxxxxxxx> wrote:
> In message <c138376686671f575ba54ab203b6df08.squirrel@xxxxxxxxxxxxxxxx>
> pdmiller@xxxxxxxxxxxxxxxxxx wrote:
> > That's ResFind 2.20.
> > There is a newer version of ResFind (3.00), available on the GAG downloads
> > page http://gag.de/software/index.html. One of the changes is to only set
> > the application directory system variable to Obey$Dir if it has not
> > already been set. That should address this issue.
> Thanks Pete, that's definitely better but I still feel ResFind is doing
> too much and the code isn't that optimal. I played around with ResFind a
> couple of years ago and ended up with what I think is a better version.
> Never bothered to send it to Herbert though.
> I'll compare the two versions and see if there's anything I could use to
> improve my version.
Done that now and the reduced use of Obey$Dir  is a clear improvement
but the changes to GetCountry I don't get. It tries to solve what seems
to be a non-existent problem and actually introduces a flaw.
If AppName$Language & ResFind$LanguagesPref are unset and no resources
can be found for the configured country it falls back to UK. If UK is
there then the variable ResFind$LanguagesSuff will be ignored, which is
incorrect. UK should only be used as the final fallback.
 I'd prefer if ResFind didn't use Obey$Dir at all. My copy of ResFind
insists that the AppName is given as a parameter and that AppName$Dir is
defined. This makes ResFind a lot cleaner.
To unsubscribe send a mail to StrongED+unsubscribe@xxxxxxxxxxxxxx
List archives at http://www.Torrens.org.uk/RO/StrongED/index.html